Skip to content

Conversation

@Fujikawas
Copy link
Member

@Fujikawas Fujikawas commented Oct 27, 2025

Motivation: precice/dumux-adapter#52.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@Fujikawas Fujikawas self-assigned this Oct 27, 2025
@Fujikawas Fujikawas marked this pull request as draft October 27, 2025 10:23
@Fujikawas Fujikawas marked this pull request as ready for review October 30, 2025 12:53
@Fujikawas Fujikawas requested a review from IshaanDesai October 30, 2025 12:54
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this case from the adapter repository. After correcting the executable name in free-flow-dumux/appl/CMakeLists.txt, I was able to run the case. The results look as expected.

@IshaanDesai IshaanDesai requested a review from MakisH November 3, 2025 22:19
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments on the structure. I still want to look closer and run the case.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping out nicely!

I still have some concerns regarding:

  • The installation automation. This also did not work for me: installdumux.log.
    • Similarly, the scripts in the root directory that seem to suggest a dumux-dumux combination only.
  • Two small and hopefully easy to fix deviations from the naming conventions.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at it together with @Fujikawas. On my system, it still fails to install dumux due to misconfigured Kokkos, which comes, e.g., from the deal.II package (and more) on Ubuntu (unless I am overlooking something else). On a clean Ubuntu 24.04 container, it works.

For @Fujikawas, building fails with a compilation issue.

Since it works on at least one reference system, let's merge and come back once we have more information.

@MakisH MakisH merged commit b3de2af into develop Dec 15, 2025
1 check passed
@MakisH MakisH deleted the dumux-example branch December 15, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants