-
-
Notifications
You must be signed in to change notification settings - Fork 129
Add tutorial of free flow over porous media #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
IshaanDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting this case from the adapter repository. After correcting the executable name in free-flow-dumux/appl/CMakeLists.txt, I was able to run the case. The results look as expected.
...r-porous-media/images/tutorials-free-flow-over-porous-media-precice-config-visualization.png
Show resolved
Hide resolved
MakisH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first comments on the structure. I still want to look closer and run the case.
MakisH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shaping out nicely!
I still have some concerns regarding:
- The installation automation. This also did not work for me: installdumux.log.
- Similarly, the scripts in the root directory that seem to suggest a dumux-dumux combination only.
- Two small and hopefully easy to fix deviations from the naming conventions.
MakisH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at it together with @Fujikawas. On my system, it still fails to install dumux due to misconfigured Kokkos, which comes, e.g., from the deal.II package (and more) on Ubuntu (unless I am overlooking something else). On a clean Ubuntu 24.04 container, it works.
For @Fujikawas, building fails with a compilation issue.
Since it works on at least one reference system, let's merge and come back once we have more information.
Motivation: precice/dumux-adapter#52.
Checklist:
changelog-entries/<PRnumber>.md.